Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Ember version with new ember-cli-version-checker API. #166

Merged
merged 2 commits into from
Apr 4, 2017
Merged

Check for Ember version with new ember-cli-version-checker API. #166

merged 2 commits into from
Apr 4, 2017

Conversation

dan-ste
Copy link
Contributor

@dan-ste dan-ste commented Apr 4, 2017

Since ember introduced the ember-source from NPM, update API usage of ember-cli-version-checker.

Remove unused treeForAddonTemplates method
@dan-ste
Copy link
Contributor Author

dan-ste commented Apr 4, 2017

For now, we have these errors during app build.

Invalid Version: undefined TypeError: Invalid Version: undefined at new SemVer (/Users/w/projects/lpserver/frontend/addons/lp-base/node_modules/ember-cli-version-checker/node_modules/semver/semver.js:281:11) at compare (/Users/w/projects/lpserver/frontend/addons/lp-base/node_modules/ember-cli-version-checker/node_modules/semver/semver.js:571:10) at Function.lt (/Users/w/projects/lpserver/frontend/addons/lp-base/node_modules/ember-cli-version-checker/node_modules/semver/semver.js:605:10) at BowerDependencyVersionChecker.DependencyVersionChecker.(anonymous function) [as lt] (/Users/w/projects/lpserver/frontend/addons/lp-base/node_modules/ember-cli-version-checker/index.js:68:26) at Class.treeForAddonTemplates (/Users/w/projects/lpserver/frontend/addons/lp-base/node_modules/ember-modal-dialog/index.js:29:13) at Class._treeFor (/Users/w/projects/lpserver/frontend/addons/lp-base/node_modules/ember-cli/lib/models/addon.js:517:33) at Class.addonTemplateFiles [as _addonTemplateFiles] (/Users/w/projects/lpserver/frontend/addons/lp-base/node_modules/ember-cli/lib/models/addon.js:898:31) at Class.compileTemplates (/Users/w/projects/lpserver/frontend/addons/lp-base/node_modules/ember-cli/lib/models/addon.js:949:81) at Class.compileAddon (/Users/w/projects/lpserver/frontend/addons/lp-base/node_modules/ember-cli/lib/models/addon.js:1008:30) at Class.treeForAddon (/Users/w/projects/lpserver/frontend/addons/lp-base/node_modules/ember-cli/lib/models/addon.js:661:26)

@andrewhavens andrewhavens merged commit 17f569f into yapplabs:master Apr 4, 2017
@andrewhavens
Copy link
Contributor

Thanks for the PR @dan-ste!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants