Skip to content

Commit

Permalink
Merge pull request #136 from yapplabs/ember-cli-and-try
Browse files Browse the repository at this point in the history
Update ember-cli and use ember try's versionCompatibility
  • Loading branch information
lukemelia committed Jul 13, 2016
2 parents 147b43b + 9ca5c18 commit 0a1e766
Show file tree
Hide file tree
Showing 16 changed files with 173 additions and 135 deletions.
19 changes: 10 additions & 9 deletions .npmignore
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
bower_components/
tests/
tmp/
dist/

/bower_components
/config/ember-try.js
/dist
/tests
/tmp
**/.gitkeep
.bowerrc
.editorconfig
.ember-cli
.gitignore
.jshintrc
.watchmanconfig
.travis.yml
.npmignore
**/.gitkeep
bower.json
ember-cli-build.js
Brocfile.js
testem.json
testem.js
27 changes: 7 additions & 20 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,37 +1,24 @@
---
language: node_js
node_js:
- "0.12"
- "4"

sudo: false

cache:
directories:
- node_modules

env:
- EMBER_TRY_SCENARIO=1.10.1
- EMBER_TRY_SCENARIO=1.11.3
- EMBER_TRY_SCENARIO=1.12.1
- EMBER_TRY_SCENARIO=1.13.10
- EMBER_TRY_SCENARIO=ember-release
- EMBER_TRY_SCENARIO=ember-beta
- EMBER_TRY_SCENARIO=ember-canary

matrix:
allow_failures:
- env: EMBER_TRY_SCENARIO=ember-beta
- env: EMBER_TRY_SCENARIO=ember-canary

before_install:
- export PATH=/usr/local/phantomjs-2.0.0/bin:$PATH
- "npm config set spin false"
- "npm install -g npm@^2"
- npm config set spin false
- npm install -g bower
- npm install phantomjs-prebuilt

install:
- npm install -g bower
- npm install
- bower install

script:
- ember try $EMBER_TRY_SCENARIO test --skip-cleanup
# Usually, it's ok to finish the test scenario without reverting
# to the addon's original dependency state, skipping "cleanup".
- ember try:each --skip-cleanup
2 changes: 1 addition & 1 deletion .watchmanconfig
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"ignore_dirs": ["tmp"]
"ignore_dirs": ["tmp", "dist"]
}
2 changes: 1 addition & 1 deletion LICENSE.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2015
Copyright (c) 2016

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

Expand Down
16 changes: 5 additions & 11 deletions bower.json
Original file line number Diff line number Diff line change
@@ -1,16 +1,10 @@
{
"name": "ember-modal-dialog",
"dependencies": {
"ember": "1.13.10",
"ember-cli-shims": "ember-cli/ember-cli-shims#0.0.3",
"ember-cli-test-loader": "ember-cli-test-loader#0.1.3",
"ember-load-initializers": "ember-cli/ember-load-initializers#0.1.5",
"ember-qunit": "0.4.15",
"ember-qunit-notifications": "0.0.7",
"ember-resolver": "~0.1.18",
"jquery": "1.11.3",
"loader.js": "ember-cli/loader.js#3.2.1",
"qunit": "~1.19.0",
"bind-polyfill": "^1.0.0"
"bind-polyfill": "^1.0.0",
"ember": "~2.6.0",
"ember-cli-shims": "0.1.1",
"ember-cli-test-loader": "0.2.2",
"ember-qunit-notifications": "0.1.0"
}
}
125 changes: 66 additions & 59 deletions config/ember-try.js
Original file line number Diff line number Diff line change
@@ -1,61 +1,68 @@
module.exports = {
scenarios: [
{
name: 'default',
dependencies: { }
},
{
name: '1.10.1',
dependencies: {
'ember': '1.10.1',
'ember-load-initializers': 'ember-cli/ember-load-initializers#0.0.2'
}
},
{
name: '1.11.3',
dependencies: {
'ember': '1.11.3',
'ember-load-initializers': 'ember-cli/ember-load-initializers#0.0.2'
}
},
{
name: '1.12.1',
dependencies: {
'ember': '1.12.1'
}
},
{
name: '1.13.10',
dependencies: {
'ember': '1.13.10'
}
},
{
name: 'ember-release',
dependencies: {
'ember': 'components/ember#release'
},
resolutions: {
'ember': 'release'
}
},
{
name: 'ember-beta',
dependencies: {
'ember': 'components/ember#beta'
},
resolutions: {
'ember': 'beta'
}
},
{
name: 'ember-canary',
dependencies: {
'ember': 'components/ember#canary'
},
resolutions: {
'ember': 'canary'
}
}
]
useVersionCompatibility: true
// scenarios: [
// {
// name: 'default',
// dependencies: { }
// },
// {
// name: '1.10.1',
// dependencies: {
// 'ember': '1.10.1',
// 'ember-load-initializers': 'ember-cli/ember-load-initializers#0.0.2'
// }
// },
// {
// name: '1.11.3',
// dependencies: {
// 'ember': '1.11.3',
// 'ember-load-initializers': 'ember-cli/ember-load-initializers#0.0.2'
// }
// },
// {
// name: '1.12.1',
// dependencies: {
// 'ember': '1.12.1'
// }
// },
// {
// name: '1.13.10',
// dependencies: {
// 'ember': '1.13.10'
// }
// },
// {
// name: '2.4.5',
// dependencies: {
// 'ember': '2.4.5'
// }
// },
// {
// name: 'ember-release',
// dependencies: {
// 'ember': 'components/ember#release'
// },
// resolutions: {
// 'ember': 'release'
// }
// },
// {
// name: 'ember-beta',
// dependencies: {
// 'ember': 'components/ember#beta'
// },
// resolutions: {
// 'ember': 'beta'
// }
// },
// {
// name: 'ember-canary',
// dependencies: {
// 'ember': 'components/ember#canary'
// },
// resolutions: {
// 'ember': 'canary'
// }
// }
// ]
};
1 change: 1 addition & 0 deletions config/environment.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/*jshint node:true*/
'use strict';

module.exports = function(/* environment, appConfig */) {
Expand Down
37 changes: 20 additions & 17 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"scripts": {
"start": "ember server",
"build": "ember build",
"test": "ember test",
"test": "ember try:each",
"deploy": "ember github-pages:commit --message \"Deploy gh-pages from commit $(git rev-parse HEAD)\"; git push; git checkout -"
},
"repository": "https://github.com/yapplabs/ember-modal-dialog",
Expand All @@ -19,30 +19,30 @@
"author": "",
"license": "MIT",
"devDependencies": {
"broccoli-asset-rev": "^2.0.2",
"ember-cli": "^1.13.8",
"ember-cli-app-version": "0.5.0",
"ember-cli-content-security-policy": "0.4.0",
"ember-cli-dependency-checker": "^1.0.1",
"broccoli-asset-rev": "^2.4.2",
"ember-ajax": "^2.0.1",
"ember-cli": "2.6.2",
"ember-cli-app-version": "^1.0.0",
"ember-cli-dependency-checker": "^1.2.0",
"ember-cli-github-pages": "0.0.6",
"ember-cli-htmlbars-inline-precompile": "^0.2.0",
"ember-cli-ic-ajax": "0.2.1",
"ember-cli-inject-live-reload": "^1.3.1",
"ember-cli-htmlbars-inline-precompile": "^0.3.1",
"ember-cli-inject-live-reload": "^1.4.0",
"ember-cli-lorem-ipsum": "0.0.2",
"ember-cli-qunit": "^1.0.0",
"ember-cli-release": "0.2.5",
"ember-cli-qunit": "^1.4.0",
"ember-cli-release": "^0.2.9",
"ember-cli-sass": "3.1.1",
"ember-cli-uglify": "^1.2.0",
"ember-code-snippet": "1.3.0",
"ember-disable-prototype-extensions": "^1.0.0",
"ember-disable-prototype-extensions": "^1.1.0",
"ember-disable-proxy-controllers": "^1.0.0",
"ember-export-application-global": "^1.0.3",
"ember-export-application-global": "^1.0.5",
"ember-legacy-views": "0.2.0",
"ember-load-initializers": "^0.5.1",
"ember-resolver": "^2.0.3",
"ember-suave": "1.2.3",
"ember-tether": "^0.3.1",
"ember-truth-helpers": "1.2.0",
"ember-try": "0.0.6",
"glob": "4.4.0"
"loader.js": "^4.0.1"
},
"dependencies": {
"ember-cli-babel": "^5.1.6",
Expand All @@ -55,6 +55,9 @@
],
"ember-addon": {
"configPath": "tests/dummy/config",
"demoURL": "http://yapplabs.github.io/ember-modal-dialog/"
"demoURL": "http://yapplabs.github.io/ember-modal-dialog/",
"versionCompatibility": {
"ember": ">1.11.0"
}
}
}
}
13 changes: 13 additions & 0 deletions testem.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/*jshint node:true*/
module.exports = {
"framework": "qunit",
"test_page": "tests/index.html?hidepassed",
"disable_watching": true,
"launch_in_ci": [
"PhantomJS"
],
"launch_in_dev": [
"PhantomJS",
"Chrome"
]
};
4 changes: 2 additions & 2 deletions tests/dummy/app/app.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Ember from 'ember';
import Resolver from 'ember/resolver';
import loadInitializers from 'ember/load-initializers';
import Resolver from './resolver';
import loadInitializers from 'ember-load-initializers';
import config from './config/environment';

let App;
Expand Down
8 changes: 4 additions & 4 deletions tests/dummy/app/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,19 @@
<meta name="description" content="">
<meta name="viewport" content="width=device-width, initial-scale=1">

{{content-for 'head'}}
{{content-for "head"}}

<link rel="stylesheet" href="assets/vendor.css">
<link rel="stylesheet" href="assets/dummy.css">

{{content-for 'head-footer'}}
{{content-for "head-footer"}}
</head>
<body>
{{content-for 'body'}}
{{content-for "body"}}

<script src="assets/vendor.js"></script>
<script src="assets/dummy.js"></script>

{{content-for 'body-footer'}}
{{content-for "body-footer"}}
</body>
</html>
3 changes: 3 additions & 0 deletions tests/dummy/app/resolver.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import Resolver from 'ember-resolver';

export default Resolver;
5 changes: 5 additions & 0 deletions tests/helpers/destroy-app.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import Ember from 'ember';

export default function destroyApp(application) {
Ember.run(application, 'destroy');
}
23 changes: 23 additions & 0 deletions tests/helpers/module-for-acceptance.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { module } from 'qunit';
import Ember from 'ember';
import startApp from '../helpers/start-app';
import destroyApp from '../helpers/destroy-app';

const { RSVP: { Promise } } = Ember;

export default function(name, options = {}) {
module(name, {
beforeEach() {
this.application = startApp();

if (options.beforeEach) {
return options.beforeEach.apply(this, arguments);
}
},

afterEach() {
let afterEach = options.afterEach && options.afterEach.apply(this, arguments);
return Promise.resolve(afterEach).then(() => destroyApp(this.application));
}
});
}
2 changes: 1 addition & 1 deletion tests/helpers/resolver.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Resolver from 'ember/resolver';
import Resolver from '../../resolver';
import config from '../../config/environment';

const resolver = Resolver.create();
Expand Down
Loading

0 comments on commit 0a1e766

Please sign in to comment.