Fix buffer notification on changes discard #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniezurawski
commented
Dec 2, 2019
| // Discard buffer changes and verify | ||
| await click('button#discard-changes'); | ||
| assert.dom('#buffer-firstname').hasText('stefan'); | ||
| assert.dom('#buffer-firstname-backward').hasText('nafets'); |
There was a problem hiding this comment.
Without a fix, the test fails here. A computed property that transforms buffered firstName property to be spelled backward is not notified about the change (on discardBufferedChanges action).
So the last change is still there (kemot).
lukemelia
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the buffer doesn't notify about changes on the
discardBufferedChangesmethod.I added a test that shows that. A computed property that depends on the buffered property is not notified about the change and it doesn't recompute on
discardBufferedChangesaction.