Upgrade to ember-cli 2.8 #28
Conversation
| @@ -1,6 +1,55 @@ | |||
| /*jshint node:true*/ | |||
| module.exports = { | |||
| // see package.json | |||
| // TLDR: 1.13.x ++ | |||
| useVersionCompatibility: true | |||
There was a problem hiding this comment.
We should retain the 1.13.x + version compatibility as it gives us more test coverage than this change.
| - ember try:each | ||
| # Usually, it's ok to finish the test scenario without reverting | ||
| # to the addon's original dependency state, skipping "cleanup". | ||
| - ember try:one $EMBER_TRY_SCENARIO test --skip-cleanup |
There was a problem hiding this comment.
This should still use the empty try version compatibility functionality merged with the .travis.yml upgrades made with 2.8.
| "name": "Ben Limmer", | ||
| "email": "hello@benlimmer.com" | ||
| } | ||
| ], |
There was a problem hiding this comment.
Please retain the existing package.json configurations merged with dependency version updates.
There was a problem hiding this comment.
Forgot about package.json. Added back the needed fields
|
Also, thank you for helping out with this PR! |
| }, | ||
| "repository": "https://github.com/yapplabs/ember-buffered-proxy", | ||
| "engines": { | ||
| "node": ">= 0.10.0" | ||
| }, | ||
| "author": "Kris Selden, Stefan Penner & Yapp Labs", | ||
| "author": "Kris Selden, Stefan Penner & Yapp Labs", + "author": "", |
|
This still needs version compatibility with ember-try restored and then I think it's good to go! |
|
@blimmer Can you relook at this |
|
I fixed one last thing and will merge after tests pass - thanks! |
No description provided.