Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js v12.18.1 on armv6, armv7 and armv8 #7

Closed
n1ru4l opened this issue Jul 7, 2020 · 10 comments
Closed

Node.js v12.18.1 on armv6, armv7 and armv8 #7

n1ru4l opened this issue Jul 7, 2020 · 10 comments

Comments

@n1ru4l
Copy link
Contributor

n1ru4l commented Jul 7, 2020

Would it be possible to also build binaries for Node.js v12.18.1 for armv6, armv7, and armv8?

@n1ru4l n1ru4l changed the title v12.18.1 on armv6, armv7 and armv8 Node.js v12.18.1 on armv6, armv7 and armv8 Jul 7, 2020
@robertsLando
Copy link
Member

robertsLando commented Jul 7, 2020 via email

@n1ru4l
Copy link
Contributor Author

n1ru4l commented Jul 7, 2020

@robertsLando Thanks for the clarification and also for the binaries 👍

@n1ru4l n1ru4l closed this as completed Jul 7, 2020
@robertsLando
Copy link
Member

@n1ru4l You welcome :)

@n1ru4l
Copy link
Contributor Author

n1ru4l commented Aug 19, 2020

@robertsLando So we are finally trying to upgrade to Node12 now and we run into a few complications.

We are using docker buildx for creating armv7 binaries (since armv6 is not available as a docker image) and not supported by debian and dropped by Node.js).

This means without a fetched-v12.18.1-linux-armv7 we are unable to build those.

Could you please consider providing binaries for armv7?

Edit: It seems building armv7 is currently broken for pkg (at least in docker buildx), as the architecture cannot be resolved reliably. This PR should fix that: https://github.com/vercel/pkg-fetch/pull/101/files

@n1ru4l n1ru4l reopened this Aug 19, 2020
@robertsLando
Copy link
Member

Your edit is the answer to your question :) Once that is sorted I will update the build script, actually if you chech how I build now you will see I select armv6 even for armv7 build on purpose to fix that

@n1ru4l
Copy link
Contributor Author

n1ru4l commented Aug 19, 2020

@robertsLando Yeah I actually figured that out already 😅 So that means it should actually work today if I would place fetched-v12.18.1-linux-armv6 as fetched-v12.18.1-linux-armv7 in the cache, is that correct?

@robertsLando
Copy link
Member

robertsLando commented Aug 19, 2020

@n1ru4l Unfortunally I rarely see a PR to be merged or at least considered with both pkg or pgk-fetch, if you don't see any response I could consider to use your branch to build pkg

@robertsLando
Copy link
Member

robertsLando commented Aug 19, 2020

So that means it should actually work today if I would place fetched-v12.18.1-linux-armv6 as fetched-v12.18.1-linux-armv7 in the cache, is that correct

That is what I'm doing in last year and I didn't have any problem. Using armv6 binaries in armv7 seems safe, just rename it and it works :) As I said in my first comment here: #7 (comment)

@n1ru4l
Copy link
Contributor Author

n1ru4l commented Aug 19, 2020

Yeah I misunderstood that comment then 🤣. check #9

@n1ru4l
Copy link
Contributor Author

n1ru4l commented Aug 21, 2020

closed by #9

@n1ru4l n1ru4l closed this as completed Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants