Support multi heap managers (#45)

* add init function in each heap manager

* add ptmalloc glibc version detection

* fix ptmalloc glibc 2.27 + gdb9.2 on Ubuntu 18.04

* move get_glibc_version to heap_ptmalloc files

* rename gHeapInitFuncs to gHeapRegistrationFuncs

* heap.cpp: add macro to check CA_HEAP and enhance its error message

Co-authored-by: Michael Yan <myan@microstrategy.com>
Former-commit-id: ed32610

.devcontainer/Dockerfile

@@ -7,6 +7,7 @@ FROM mcr.microsoft.com/vscode/devcontainers/cpp:0-${VARIANT}
 # [Optional] Uncomment this section to install additional packages.
 RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
     && apt install -y texinfo \
+    && apt install -y libgmp-dev \
     && apt install -y build-essential \
     && apt install -y wget \
     && apt install -y python-dev \

gdbplus/gdb-12.1/gdb/Makefile.in

@@ -1092,6 +1092,8 @@ COMMON_SFILES = \
 	go-typeprint.c \
 	go-valprint.c \
 	heap.c \
+	heap_ptmalloc_2_27.c \
+	heap_ptmalloc_2_31.c \
 	heap_ptmalloc_2_35.c \
 	heapcmd.c \
 	i386-decode.c \

gdbplus/gdb-12.1/gdb/gdb_dep.c

@@ -48,6 +48,37 @@ inferior_memory_read (address_t addr, void* buffer, size_t sz)
 		return false;
 }
 
+void ca_switch_to_thread(struct thread_info *info)
+{
+    switch_to_thread (info);
+}
+
+int ca_num_fields(struct type *type)
+{
+    return type->num_fields();
+}
+
+const char *ca_field_name(struct type *type, int i)
+{
+    return type->field(i).name();
+}
+
+bool get_gv_value(const char *varname, char *buf, size_t bufsz)
+{
+	struct symbol *sym;
+
+	sym = lookup_static_symbol(varname, VAR_DOMAIN).symbol;
+	if (sym) {
+		struct value *val = value_of_variable(sym, 0);
+		if (bufsz >= TYPE_LENGTH(value_type(val))) {
+			gdb::array_view<const gdb_byte> content = value_contents(val);
+			memcpy(buf, content.data(), TYPE_LENGTH(value_type(val)));
+			return true;
+		}
+	}
+	return false;
+}
+
 static int
 thread_callback (struct thread_info *info, void *data)
 {
@@ -379,8 +410,6 @@ build_segments(void)
 bool
 update_memory_segments_and_heaps(void)
 {
-	bool rc = true;
-
 	/* reset internal quit flag */
 	g_quit = false;
 
@@ -422,9 +451,7 @@ update_memory_segments_and_heaps(void)
 		return false;
 	}
 	/* Probe for heap segments */
-	CA_HEAP->init_heap();
-
-	return rc;
+    return init_heap_managers();
 }
 
 int

gdbplus/gdb-12.1/gdb/heap_ptmalloc_2_27.c

@@ -0,0 +1 @@
+../../../src/heap_ptmalloc_2_27.cpp

gdbplus/gdb-12.1/gdb/heap_ptmalloc_2_31.c

@@ -0,0 +1 @@
+../../../src/heap_ptmalloc_2_31.cpp

gdbplus/gdb-12.1/gdb/heapcmd.c

@@ -265,6 +265,10 @@ display_help_command (const char *arg, int from_tty)
 static void
 switch_heap_command(const char *arg, int from_tty)
 {
+	/* Ensure heap manager is initialized */
+	if (!update_memory_segments_and_heaps())
+		return;
+
 	if (!arg) {
 		auto supported_heaps = get_supported_heaps();
 		CA_PRINT("Please provide the heap manager name, currently supported heap managers: %s.\n", supported_heaps.c_str());
@@ -292,7 +296,6 @@ void _initialize_heapcmd ();
 void
 _initialize_heapcmd ()
 {
-	register_heap_managers(); // todo: find a better place to register heaps. maybe update_memory_segments_and_heaps is better than here.
 	add_cmd("ref", class_info, ref_command, _("Search for references to a given object.\nref <addr_exp>\nref [/thread or /t] <addr_exp> <size> [level]"), &cmdlist);
 	add_cmd("obj", class_info, obj_command, _("Search for object and reference to object of the same type as the input expression\nobj <type|variable>"), &cmdlist);
 	add_cmd("shrobj", class_info, shrobj_command, _("Find objects that currently referenced from multiple threads\nshrobj [tid0] [tid1] [...]"), &cmdlist);

gdbplus/gdb-9.2/gdb/Makefile.in

@@ -1063,7 +1063,9 @@ COMMON_SFILES = \
 	go-typeprint.c \
 	go-valprint.c \
 	heap.c \
-	heap_ptmalloc.c \
+	heap_ptmalloc_2_27.c \
+	heap_ptmalloc_2_31.c \
+	heap_ptmalloc_2_35.c \
 	heap_tcmalloc.c \
 	heapcmd.c \
 	i386-decode.c \

gdbplus/gdb-9.2/gdb/gdb_dep.c

@@ -48,6 +48,37 @@ inferior_memory_read (address_t addr, void* buffer, size_t sz)
 		return false;
 }
 
+void ca_switch_to_thread(struct thread_info *info)
+{
+    switch_to_thread (info->ptid);
+}
+
+int ca_num_fields(struct type *type)
+{
+    return TYPE_NFIELDS (type);
+}
+
+const char *ca_field_name(struct type *type, int i)
+{
+    return TYPE_FIELD_NAME (type, i);
+}
+
+bool get_gv_value(const char *varname, char *buf, size_t bufsz)
+{
+	struct symbol *sym;
+
+	sym = lookup_static_symbol(varname, VAR_DOMAIN).symbol;
+	if (sym) {
+		struct value *val = value_of_variable(sym, 0);
+		if (bufsz >= TYPE_LENGTH(value_type(val))) {
+			const gdb_byte *content = value_contents(val);
+			memcpy(buf, content, TYPE_LENGTH(value_type(val)));
+			return true;
+		}
+	}
+	return false;
+}
+
 static int
 thread_callback (struct thread_info *info, void *data)
 {
@@ -382,8 +413,6 @@ build_segments(void)
 bool
 update_memory_segments_and_heaps(void)
 {
-	bool rc = true;
-
 	/* reset internal quit flag */
 	g_quit = false;
 
@@ -425,9 +454,7 @@ update_memory_segments_and_heaps(void)
 		return false;
 	}
 	/* Probe for heap segments */
-	CA_HEAP->init_heap();
-
-	return rc;
+    return init_heap_managers();
 }
 
 int

gdbplus/gdb-9.2/gdb/heap_ptmalloc_2_27.c

@@ -0,0 +1 @@
+../../../src/heap_ptmalloc_2_27.cpp

gdbplus/gdb-9.2/gdb/heap_ptmalloc_2_31.c

@@ -0,0 +1 @@
+../../../src/heap_ptmalloc_2_31.cpp

gdbplus/gdb-9.2/gdb/heap_ptmalloc_2_35.c

@@ -0,0 +1 @@
+../../../src/heap_ptmalloc_2_35.cpp

gdbplus/gdb-9.2/gdb/heapcmd.c

@@ -289,7 +289,6 @@ switch_heap_command(const char *arg, int from_tty)
 void
 _initialize_heapcmd (void)
 {
-	register_heap_managers(); // todo: find a better place to register heaps. maybe update_memory_segments_and_heaps is better than here.
 	add_cmd("ref", class_info, ref_command, _("Search for references to a given object.\nref <addr_exp>\nref [/thread or /t] <addr_exp> <size> [level]"), &cmdlist);
 	add_cmd("obj", class_info, obj_command, _("Search for object and reference to object of the same type as the input expression\nobj <type|variable>"), &cmdlist);
 	add_cmd("shrobj", class_info, shrobj_command, _("Find objects that currently referenced from multiple threads\nshrobj [tid0] [tid1] [...]"), &cmdlist);