Make wrap-multilines more granular #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok to add these options to the rule. Can you update the documentation too ? Then I think we'll be good to merge. |
This adds an option for enabling/disabling wrap-multilines in the context of the enclosing expression. In facebook/react, we only care about jsx expressions in return statements: facebook/react#4007 (comment)
|
@yannickcr Fixed. |
yannickcr
added a commit
that referenced
this pull request
Jun 3, 2015
Make wrap-multilines more granular
|
Thanks! |
|
Seeing as we have an outstanding PR depending on this commit (facebook/react#4007), is there a chance you'll cut a new release soon, or would you recommend we use a git commit hash in our dependencies? |
|
No need for the commit hash, a new release should come out soon. |
|
|
|
Awesome! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option for enabling/disabling wrap-multilines in the context of the enclosing expression. In facebook/react, we only care about jsx expressions in return statements