Enable more eslint-plugin-react rules #4007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <WrapComponent> | ||
| <div /> | ||
| <span /> | ||
| </WrapComponent>; | ||
| </WrapComponent> | ||
| ); |
There was a problem hiding this comment.
Our style guide actually says the opposite for these and we (usually) only wrap with parens at return statements. Might be worth forking the rule or seeing if we can get an option added upstream.
bgw
force-pushed
the
eslint-plugin-react
branch
2 times, most recently
from
1d755e6
to
99a28f2
Compare
This should contain all the rules we probably want to use, except react/wrap-multilines, which requires a larger codemod, and would clutter this commit.
Multiline jsx literals in a return should be paren-wrapped.
bgw
added a commit
that referenced
this pull request
Jun 4, 2015
Enable more eslint-plugin-react rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should contain all the rules we probably want to use. This is divided into two commits to make it easier to review.
The wrap-multiline codemod commit was mostly made using: