feat: Adds show_set_totals argument to display set totals
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new argument, `show_set_totals`, to the `ggvenn` and `geom_venn` functions. This allows users to optionally display the total count and/or percentage for each set in the Venn diagram. The `show_set_totals` argument accepts the following values: * `"c"`: Show only the count for each set. * `"p"`: Show only the percentage for each set. * `"cp"`: Show both the count and percentage for each set. * `"none"`: Hide the set totals (default). This new feature provides users with more information about the composition of their Venn diagrams and enhances the overall clarity of the visualization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to the
ggvennpackage, allowing users to display the total count and/or percentage for each set in the Venn diagram using theshow_set_totalsargument. This addresses the request in issue #28 for a more informative Venn diagram display.Motivation:
Currently,
ggvennonly displays the counts or percentages within the intersections of the Venn diagram. However, users may also want to see the total counts or percentages for each individual set, providing a more complete understanding of the data, as requested in issue #28.Implementation:
The new
show_set_totalsargument accepts the following values:"c": Show only the count for each set."p": Show only the percentage for each set."cp": Show both the count and percentage for each set."none": Hide the set totals (default).This argument provides users with flexibility in choosing how to display set totals in their Venn diagrams.
Closes #28