Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move zookeeper.py in chadmin #70

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Move zookeeper.py in chadmin #70

merged 4 commits into from
Oct 5, 2023

Conversation

MikhailBurdukov
Copy link
Contributor

@MikhailBurdukov MikhailBurdukov commented Oct 3, 2023 •
edited
Loading

  • ClickHouse-host functionality has been moved to chadmin.
  • Refactored: tree traversal has been replaced from recursive to iterative one(bfs).
  • Added tests for clickhouse-hosts-cleanup cmd.

Also tested it manually on clusters, and the results with old scripts are similar to the new ones.

@MikhailBurdukov MikhailBurdukov marked this pull request as ready for review October 3, 2023 13:59
Alex-Burmak
Alex-Burmak reviewed Oct 5, 2023
View reviewed changes
tests/features/chadmin_zookeeper.feature Outdated
@@ -0,0 +1,43 @@
Feature: keeper-monitoring tool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a copy-paste error.

@MikhailBurdukov
Copy link
Contributor Author

@GrigoryPervakov also reviewed PR, said : lgtm.

@MikhailBurdukov MikhailBurdukov merged commit 8c07351 into main Oct 5, 2023
18 checks passed
@MikhailBurdukov MikhailBurdukov deleted the MDB-25320-move_clickhouse_cleanup branch October 5, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-Burmak Alex-Burmak Alex-Burmak approved these changes

@ianton-ru ianton-ru Awaiting requested review from ianton-ru

@GrigoryPervakov GrigoryPervakov Awaiting requested review from GrigoryPervakov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikhailBurdukov @Alex-Burmak