Added error handle to orphaned objects monitoring #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaUnisikhin
force-pushed
the
orp-objects-error-field
branch
from
eb5cca9 to
b65b633
Compare
NikitaUnisikhin
force-pushed
the
orp-objects-error-field
branch
from
b65b633 to
351fcdf
Compare
NikitaUnisikhin
changed the title
NikitaUnisikhin
force-pushed
the
orp-objects-error-field
branch
14 times, most recently
from
d14b1f7 to
fb29816
Compare
NikitaUnisikhin
force-pushed
the
orp-objects-error-field
branch
from
9a9b434 to
e93101e
Compare
NikitaUnisikhin
changed the title
NikitaUnisikhin
changed the title
aalexfvk
reviewed
Nov 1, 2024
| @@ -195,3 +211,10 @@ def _table_formatter(stats): | |||
| print_response( | |||
| ctx, clean_stats, default_format="table", table_formatter=_table_formatter | |||
| ) | |||
|
|
|||
|
|
|||
| def create_orphaned_objects_state(total_size: int, error_msg: str) -> dict: | |||
There was a problem hiding this comment.
How about creating a dataclass for this purpose with methods to_json() and from_json() ?
There was a problem hiding this comment.
I agree, done
NikitaUnisikhin
force-pushed
the
orp-objects-error-field
branch
2 times, most recently
from
4794cbe to
9aee5e8
Compare
NikitaUnisikhin
force-pushed
the
orp-objects-error-field
branch
from
9aee5e8 to
a12d555
Compare
aalexfvk
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.