Add explicit @types/d3-time dependency #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @yamass, first up, thanks for the neat little library here!
I was having some trouble using d3-luxon from a typescript + pnpm project, and I think it's due to the typings referencing types from d3-time explicitly, despite it not being listed as a dependency. In pnpm, dependencies aren't hoisted like in npm/yarn, so the typings aren't on disk in the place that allows typescript to find them, so I believe that adding this dep will ensure that pnpm puts the types in the node_modules folder.