Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot insert data using addtags by mode mix #356

Closed
zuliandri2 opened this issue Nov 27, 2019 · 6 comments · Fixed by #360
Closed

cannot insert data using addtags by mode mix #356

zuliandri2 opened this issue Nov 27, 2019 · 6 comments · Fixed by #360

Comments

@zuliandri2
Copy link

zuliandri2 commented Nov 27, 2019 •
edited
Loading

Hi all

I tried to insert data using addtags, bui it cannot be tags
you can see in my code, how to make it?
I am using 2.9.9, when I change to latest version, the result is the same

https://jsbin.com/maxizunaso/edit?html,js,output
@yairEO
Copy link
Owner

yairEO commented Nov 27, 2019

I will check and let you know

yairEO added a commit that referenced this issue Nov 28, 2019
@yairEO
- Show dropdown on arrow down #333
6de7300 
- fixed #267 - Pasted text separated with new line symbol doesn't process correctly
- fixed #356 - addTags not working on mix-mode
@zuliandri2
Copy link
Author

zuliandri2 commented Nov 29, 2019 •
edited
Loading

Hi @yairEO

I thought it will be work in mix mode when I used addTags in my function
I resolve with loadOriginalValues
but first must be insert value, before call loadOriginalValues,
now my problem is delimeters, it must be has a delimeter, without delimeter it will not become tags
max length the text is only valid 100 characters

Thanks @yairEO

@yairEO
Copy link
Owner

yairEO commented Nov 29, 2019 •
edited
Loading

I am currently on away vacation but have pushed a fix for this to my experimental v3 branch, so you are free to try it until I come back on Monday

@yairEO
Copy link
Owner

yairEO commented Dec 3, 2019

I will release v3 this week which will have this fixed

@yairEO yairEO mentioned this issue Dec 12, 2019
Merged
yairEO added a commit that referenced this issue Dec 12, 2019
@yairEO
V3 (#360)
a31fc26 
- do not add multiple   after the last tag, in mixed-mode (happens if initial input value has multiline)
- re-wrote "replaceTextWithNode" method completely and renamed it "replaceTextWithNode"
- fix bug where unintended mixed-mode prefixes are removed instead of only the one needed
- fix bug with mixed-mode dropdown not removed when Tagify de-focus
- Changes to "autoComplete" setting. added "rightKey" sub-setting
- when dropdown is shown, pressing ESC key should not create a new tag, but only hide the dropdown
- improve the auto-comeplete setting with sub-settings for "enter" & "right" keys functionality (issue #103)
- on fuzzy-search, only auto-complete the input with terms starts with the typed text
- added loader animations to the CSS and "loading" method to Tagify
- single-value select mode refactoring
- demo page - suggestion list as tags that when clicked add the clicked tag
- renamed jQuery event "remove" to "removeTag" #222
- make demo page header fixed to top
- all triggered events return the instance's scope (tagify)
- add methods to the README (replaceTag)
- improved CSS dropdown animations (on show)
- Show dropdown suggestions list on arrow down #333
- fixed #267 - Pasted text separated with new line symbol doesn't process correctly
- fixed #356 - addTags not working on mix-mode
- add boolean property to "this.dropdown" that would tell if the dropdown is shown or not
- show suggestions dropdown when editing a tag
- add event: "edit:keydown"
- new event: "edit:input"
- new event: "edit:change"
- new event: "edit:start"
- added dropdown ability to use css effects when showing
- dropdown auto-adjusts its placement if there's no space for it at the bottom, it will flip to be above
@yairEO
Copy link
Owner

yairEO commented Dec 12, 2019

Just released version 3.0.0. Try updating. Now addTags method should work for mix mode and should add a tag at the end of the content

@zuliandri2
Copy link
Author

Hi @yairEO
Thank's for updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

V3 yairEO/tagify
2 participants
@yairEO @zuliandri2