Skip to content
This repository has been archived by the owner on Dec 20, 2022. It is now read-only.

[patch] add log on authZ error #96

Merged
merged 4 commits into from
Nov 14, 2022
Merged

[patch] add log on authZ error #96

merged 4 commits into from
Nov 14, 2022

Conversation

t4niwa
Copy link
Contributor

@t4niwa t4niwa commented Nov 2, 2022

Description

Print info log for authorize (roletoken, check policy roles)

Type of change

  • Bug fix
  • New feature
  • Refactoring (no functional changes, no api changes)
  • Non-code changes (update documentation, pipeline, etc.)

Flags

  • breaks backward compatibility
  • requires a documentation update
  • has untestable code

Checklist

  • Followed the guidelines in the CONTRIBUTING document
  • Added prefix [major]/[minor]/[patch]/[skip] in the PR title
  • Tested and linted the code
  • Commented the code
  • Made corresponding changes to the documentation
  • Confirmed no dropping in test coverage (by Codecov)
  • Passed all pipeline checking
  • Approved by >1 reviewer

Checklist for maintainer

  • Use Squash and merge
  • Double-confirm the merge message has prefix [major]/[minor]/[patch]/[skip]
  • Delete the branch after merge

Copy link
Contributor

@WindzCUHK WindzCUHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glg.Debugf("error parse and validate access token, err: %v", err)

debug => info

return nil, err

add log?

glg.Infof("translator error, err: %v, principal: %s, action: %s, resource: %s", err, p.Name(), act, res)

role/processor.go Outdated Show resolved Hide resolved
role/processor.go Outdated Show resolved Hide resolved
policy/daemon.go Outdated Show resolved Hide resolved
authorizerd.go Outdated Show resolved Hide resolved
@WindzCUHK
Copy link
Contributor

authorizer にログを出るのが十分と思うので、一旦 proxy 側の修正を戻ります。
yahoojapan/authorization-proxy@8755561

taniwa added 2 commits November 9, 2022 19:19
@WindzCUHK WindzCUHK merged commit 9d1e128 into master Nov 14, 2022
@WindzCUHK WindzCUHK deleted the print-authz-log branch November 14, 2022 08:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants