This repository has been archived by the owner on Dec 20, 2022. It is now read-only.
[patch] Fix authorize #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
- Coverage 94.66% 94.29% -0.38%
==========================================
Files 19 19
Lines 1257 1263 +6
==========================================
+ Hits 1190 1191 +1
- Misses 45 50 +5
Partials 22 22
Continue to review full report at Codecov.
|
kyfujisa
reviewed
Aug 14, 2020
| return nil | ||
| }, | ||
| } | ||
| }(), |
There was a problem hiding this comment.
How about adding a test case like the following?
- disablePolicyd:
truefalse - wantResult: p
- checkFunc: check
prov.cache.Get("dummyTok" + "dummyAct" + "dummyRes")is ok
There was a problem hiding this comment.
Sorry, I made a mistake.
What I meant to say was the test with disablePolicyd set to false.
Fixed the comment above.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
description_with_details_and_reasoning
Type of change
Flags
Related issue/PR
Delete if not applicable
Checklist
[major]/[minor]/[patch]/[skip]in the PR titleChecklist for maintainer
Squash and merge[major]/[minor]/[patch]/[skip]