Introduce support for Infinity #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about |
|
Nice catch ! Just implemented on 4599ec6. |
okuryu
reviewed
Feb 12, 2020
test/unit/serialize.js
Outdated
| }); | ||
|
|
||
| it('should deserialize a map', function () { | ||
| var m = eval(serialize(new Map([ | ||
| ['a', 123], | ||
| [null, 456] | ||
| [null, 456], | ||
| [Infinity,322] |
There was a problem hiding this comment.
I think it should be 789 to match the above regularity.
There was a problem hiding this comment.
I failed to notice the sequential suit. Here you are: 6ac6afe
okuryu
approved these changes
Feb 16, 2020
|
Published v3.0.0. Thanks! |
This was referenced Mar 8, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
Infinityvalue (previously converted tonull).I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.