Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Graphql integration test #954

Merged
merged 17 commits into from
Sep 6, 2019
Merged

Conversation

hellohanchen
Copy link
Contributor

@hellohanchen hellohanchen commented Sep 5, 2019

Resolves #941

Description

Update graphql java integration test, fix some bugs that cause graphql integration tests to fail

  • pick commits from Graphql it #945
  • Create new Book and Author before each test
  • Remove @Disable annotation on tests

License

I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@coveralls
Copy link
Collaborator

coveralls commented Sep 5, 2019

Coverage Status

Coverage decreased (-0.06%) to 76.303% when pulling 0cc9667 on hellohanchen:fix-graqlit into 6254f83 on yahoo:master.

selection(
field(
"book",
// argument(argument("ids", "\"2\"")),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncomment.

@aklish aklish merged commit b0aaf30 into yahoo:master Sep 6, 2019
@hellohanchen hellohanchen deleted the fix-graqlit branch February 18, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants