Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE 864 Fix primitive id field RSQL filter #866

Merged
merged 7 commits into from
Oct 3, 2019

Conversation

hellohanchen
Copy link
Contributor

In #814, INFIX, POSTFIX and PREFIX RSQL filters are supported for Number.class. But for primitive classes, the check Number.class.isAssignableFrom(relationshipType) would not work.

Possible Solution

Number.class.isAssignableFrom(relationshipType) || relationshipType == long.class || relationshipType == int.class

Steps to Reproduce (for bugs)

Create a class with id field type long and run a filter id=="*1*" on that would return InvalidValueException: Invalid value: *1*

@coveralls
Copy link
Collaborator

coveralls commented Jun 26, 2019

Coverage Status

Coverage decreased (-0.01%) to 76.339% when pulling f0c4b82 on hellohanchen:issue_864 into 0f354bd on yahoo:master.

@aklish aklish merged commit 0442484 into yahoo:master Oct 3, 2019
@hellohanchen hellohanchen deleted the issue_864 branch February 18, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants