Improve performance of initial class scans #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklish
previously approved these changes
Mar 26, 2020
aklish
previously approved these changes
Mar 26, 2020
wcekan
force-pushed
the
registerCustomSerde
branch
from
5751a06 to
f6b66cb
Compare
aklish
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved performance of
ClassScannerby limiting the collected data to that required.Allow Elide subclass to disable or enhance
registerCustomSerdeby making the private method protected.Motivation and Context
Initial Elide startup was taking many minutes in registerCustomSerde, which affected our product integration tests.
How Has This Been Tested?
Tested locally with our product build.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.