Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql generated schema does not adhere to graphql spec. #1007

Closed
cythrawll opened this issue Oct 10, 2019 · 0 comments · Fixed by #1014
Closed

graphql generated schema does not adhere to graphql spec. #1007

cythrawll opened this issue Oct 10, 2019 · 0 comments · Fixed by #1014

Comments

@cythrawll
Copy link
Collaborator

Expected Behavior

graphql clients to not throw errors because of reserved names.
https://graphql.github.io/graphql-spec/draft/#sec-Reserved-Names

Current Behavior

when using an introspection with clients I get the following error:

graphiql.js:24539 Uncaught Error: Name "__root" must not begin with "__", which is reserved by GraphQL introspection.

Name "__edges__post" must not begin with "__", which is reserved by GraphQL introspection.

Name "__node__post" must not begin with "__", which is reserved by GraphQL introspection.

Name "__edges__comment" must not begin with "__", which is reserved by GraphQL introspection.

Name "__node__comment" must not begin with "__", which is reserved by GraphQL introspection.

Name "__edges__account" must not begin with "__", which is reserved by GraphQL introspection.

Name "__node__account" must not begin with "__", which is reserved by GraphQL introspection.

Name "__pageInfoObject" must not begin with "__", which is reserved by GraphQL introspection.

Name "__mutation_root" must not begin with "__", which is reserved by GraphQL introspection.

Possible Solution

rename these types with a single underscore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant