-
Notifications
You must be signed in to change notification settings - Fork 39
refactored tests for mocha and tweaked some internals #10
Conversation
3f33196
to
471fd35
Compare
Woot, tests are all passing now on all node versions.. |
- "0.12" | ||
- "4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might as well throw 5 in here. people are using it in prod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
"yui-lint": "~0.2.0" | ||
}, | ||
"dependencies": { | ||
"lodash.clone": "~4.3.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay!
}, function (err) { | ||
that.callback(err,dns.internalCache); | ||
describe('dnscache main test suite', function() { | ||
this.timeout(10000); //dns queries are slow.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it may be worth stubbing the original dns functions so as to speed up these tests. we shouldn't be interested in testing that require('dns')
works... (non-blocker)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there are also some setTimeout
's in the tests too that this was to account for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that's dangerous.
ok LGTM with the following caveats to be sorted out in later PRs:
and one potential doozie (also a non-blocker):
|
Agreed on all points. I'll work on those items next. Let's just not publish 1.0.0 until we handle those. |
This is a pretty large PR 😄
I did:
mocha
if/else
for handling errors to beif (err) { return callback(err); }
stylecallback
oncache.get
deepCopy
withlodash.close
for perf.1.0.0