Controller name case

[lewispb]

This allows configuration of the case of controller names in metrics.

Yabeda::Rails.config.controller_name_case = :camel

# rails_request_duration_seconds_bucket{action="show",controller="Accounts::Domains::TwoFactorAuthenticationsController",format="html",le="+Inf",method="get",status="200"} 1

Yabeda::Rails.config.controller_name_case = :snake # (default)

# rails_request_duration_seconds_bucket{action="show",controller="accounts/domains/two_factor_authentications",format="html",le="+Inf",method="get",status="200"} 1

This is important for us so we can correlate metrics between different systems, like logs and traces.

I introduced a new Yabeda::Rails::Event class to support this change, and so also extracted event-specific concerns from the long Yabeda::Rails.install! method into the new Event class.

[Envek]

Thank you for your pull request! I'm fine with this addition in general, just need to clean up the pull request a bit.

P.S> And also please fix linters!

[Envek]

Please drop debugging puts 😄

Suggested change

puts labels

[lewispb]

@Envek this violates the lint rule of a maximum of 5 lines in a spec. I'd suggest this is as compact as we should make this test. Do you want me to add a Rubocop exception comment?

[Envek]

Fixed it here by nesting into context and moving setup code to around hook.

[lewispb]

Nice, thanks @Envek. Been a while since I used Rspec!

I see the class comments now too - will make sure I use those in future.

[Envek]

Released in 0.9.0, please enjoy.