Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken PROJECT_VERSION_FULL #5

Closed
kloetzl opened this issue Mar 28, 2015 · 5 comments
Closed

broken PROJECT_VERSION_FULL #5

kloetzl opened this issue Mar 28, 2015 · 5 comments

Comments

@kloetzl
Copy link
Contributor

kloetzl commented Mar 28, 2015

Trying to build libdivsufsort fails early in the make process. The error is in the config.h:

/** Define to the version of this package. **/
#define PROJECT_VERSION_FULL "2.0.1-11-g735637c
"

So somehow an extra newline is added there. Deleting that fixes the problem. Unfortunately, I don't speak cmake, so I don't know how to fix that. 😉

Cheers
Fabian Klötzl
@crashfrog crashfrog mentioned this issue May 6, 2015
Open
kloetzl added a commit to kloetzl/libdivsufsort that referenced this issue Jun 3, 2015
@kloetzl
strips whitespace from version string
369151a 
This fixes a build issue where the version string would contain a line break. Closes issue y-256#5.
@kloetzl kloetzl mentioned this issue Jun 3, 2015
Merged
@kloetzl
Copy link
Contributor Author

kloetzl commented Jun 3, 2015

Fixed in pull request #7.

@simongog
Copy link

simongog commented Sep 6, 2015

I have the same issue. Are you planning to merge @kloetzl solution soon? Thanks.

@kloetzl
Copy link
Contributor Author

kloetzl commented Sep 6, 2015

For the record: libdivsufsort now has a Debian package. That avoids this issue and has improved multi-arch support with patches from @thinred.

@xpflow
Copy link

xpflow commented Sep 6, 2015

The patch referred by @kloetzl is here btw: https://sources.debian.net/src/libdivsufsort/2.0.1-2/debian/patches/0001-Fix-upstream-cmake-files-to-support-multi-arch.patch/

@simongog
Copy link

simongog commented Sep 6, 2015

Thanks for pointing this out @kloetzl and @xpflow .

@kloetzl kloetzl mentioned this issue Sep 13, 2015
Closed
@y-256 y-256 closed this as completed in 5f60d6f Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simongog @kloetzl @xpflow