Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors associated with incorrect skeleton map parsing #10

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

ryanjsims
Copy link
Contributor

The skeleton maps can have multiple remapping layers which were not being parsed correctly and caused a crash when exporting the skeleton of certain models (exosuit and others for example)

This fixes the crash but doesn't perfectly export the models with multiple remapping layers, some vertices will be associated to the wrong bone - there likely is some data that we need to use to figure out the correct skeleton map and the correct remapping layer for each vertex. It still needs more research, obviously

…ile exporting the exosuit and probably other models
@ryanjsims
Copy link
Contributor Author

You can see in this screenshot how there is some geometry attached to the knee joint that shouldn't be on the back of the mech.
image

@xypwn
Copy link
Owner

xypwn commented Jun 10, 2024

Seems like you're making good progress. Nice work and thanks a lot for sharing!

@xypwn xypwn merged commit 7b3e031 into xypwn:master Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants