Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude item whether it's a file or a directory #112

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Exclude item whether it's a file or a directory #112

merged 1 commit into from
Oct 1, 2020

Conversation

vvrein
Copy link
Contributor

@vvrein vvrein commented Sep 30, 2020

No description provided.

@xy2z
Copy link
Owner

xy2z commented Sep 30, 2020

Thanks @vvrein
Looks good, i willl have to test it out later.
But the documentation (README) also needs to be changed. I think it's easiest to keep the config name "exclude_files" for upgrading purposes, but I think the text "List of files to exclude. Supports regex if the format is /regex/i." should be updated to include dirs. And I believe the text is also in the default config file.

@vvrein
Copy link
Contributor Author

vvrein commented Sep 30, 2020

Ok, I see, thanks, will try to fix this!

@vvrein
Copy link
Contributor Author

vvrein commented Sep 30, 2020

I doubt about or || and terminology in this case.
or - can be understood like just files OR just directories
and - 🤔
Any thoughts?

@xy2z
Copy link
Owner

xy2z commented Sep 30, 2020

'Or' is fine, i think most people can understand that.

@xy2z xy2z merged commit 0cc68d3 into xy2z:develop Oct 1, 2020
@xy2z
Copy link
Owner

xy2z commented Oct 1, 2020

Works great 👍 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants