This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Stop continuous ajax requests in select2 #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohdsayed
commented
Apr 19, 2017
| @@ -69,7 +69,10 @@ | |||
| }); | |||
| request.done( success ); | |||
| request.fail( failure ); | |||
| } | |||
|
|
|||
| return request; | |||
There was a problem hiding this comment.
select2 already handles aborting the request for us if we return request in transport method.
westonruter
approved these changes
Apr 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When we type to select a post in post-select-lookup select2 input , it sends continuous ajax requests for each letter we type without any delay. Ideally the previous request should cancel each time a new request is sent and there should be at least some delay. This PR fixes that issue.
Example of Issue:
