-
Notifications
You must be signed in to change notification settings - Fork 37
Feature/issue 56 Post Date Control Reset UI #208
Feature/issue 56 Post Date Control Reset UI #208
Conversation
@@ -1 +1 @@ | |||
Subproject commit ce4fce1c1489b1d61844af8ef1dffea897462b29 | |||
Subproject commit 449182d5615568beb5a406dbc5358004c29896ed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the submodule change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't do anything to it, just fetched & pulled it after there was another fix from your end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I did miss the submodule update. Will add that to my pull and fetch bash function. Thanks!
I'll fix up these issues in the other PR. Thanks! |
@@ -119,9 +120,11 @@ | |||
} | |||
} ); | |||
control.resetTimeButton.hide(); | |||
control.resetTimeWrap.hide(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we use addClass
/removeClass
with .hidden
class may be, instead of show()
/hide()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the benefit of doing that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR refines the date reset UI. Lesser UI is better UI :)