Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info box with a message regarding performed auto-upgrade process for pro apps #153

Open
petrenkonikita112263 opened this issue Nov 8, 2023 · 5 comments

Comments

@petrenkonikita112263
Copy link

petrenkonikita112263 commented Nov 8, 2023

Currently, the License application provides the availability to set Auto Upgrade, which will trigger a certain job for checking the newest version for pro apps. Enabling it removes the need for the manual check and update process from the Extension Manager.

guupjgYiFQ

The result is that pro apps will have a recent version.

However, all this job is performed in the background, and it's hard to trace the operation of what exactly pro apps were updated and when exactly, even for advanced users or admin users of XWiki. What can be done - to display the info box under or below the license table with the message "The extension {pro app_name} was upgraded from {old_version_number} to {new_version_number} at {date}" a bit similar to what Extension Manager provides on the execution of XWiki "Indexed on {date}".

@oanalavinia
Copy link
Contributor

Hi! I'm not sure if this is a valid improvement since what you are describing it's already implemented. Currently, there is a notification send when an upgrade is done, only that users need to opt in for it (it cannot be done by us) . Check #88 (comment) for more details
What I think it would be best, is to have some information about it somewhere else then on the issue, since it happened before as well that users didn't knew about this feature

@petrenkonikita112263
Copy link
Author

petrenkonikita112263 commented Nov 8, 2023

Yes, I checked it and saw in the code where this line is represented. But by default, the notifications regarding auto upgrade are disabled and not many users (even admins) enabled it. I can't find any mention in documentation that it should be enabled after auto-upgrade is enabled or not.

And why not to duplicate this type of information (from notification) on license page?

@oanalavinia
Copy link
Contributor

Duplicating information is not ok. What I said is that this improvement should be reformulated to be about making the existing option known to users, because this is the actual problem. So instead of duplicating the notification on the licensing page, we could add there a notice for users that they need to opt-in for notifications about the auto-upgraded feature, if they want to know about them

@oanalavinia
Copy link
Contributor

oanalavinia commented Nov 13, 2023

To be more precise, the auto-upgrades feature does not have documentation somewhere else than on the issue that added this feature #88 and this is the real problem.
Indeed, because of this lack of documentation, the Auto Upgrade button from the Licenses page can be misleading since you expect that enabling it will also imply a notification when something is done. And since users will not look for the issue where the feature was added, they will not know what to do. This leads to issues like #153 and #120

So, what I propose is to update this issue to be about making these configurations known to the user. WDYT @petrenkonikita112263 , it's ok if I change it?

@petrenkonikita112263
Copy link
Author

Okay, I agree with mentioned suggestion and you can change the title of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants