Skip to content

Commit

Permalink
All chnages
Browse files Browse the repository at this point in the history
- Upgrade to rails 4.2
- Upgrade devise
	- remove token authentication as it is not supported by the devise heartcombo/devise#2739
	- Add devise secret token
	- Signout by default now uses delete instead of get so need to change that back to get
- Model level changes
	- Rails update scopes to use lambda expressions
	- Added protected attributes gem
	- Removed attributes accessor
- Controller level changes
	- Added strong parameters in startup
- Config level Changes
	- Added eager load options
	- Rails config file rewrite
	- remove assets groups
	- Set log level to info in production
	- set css and js compressors
	- Added asstes precompiler
	- remove assets groups
	- require rails all
- Route Changes
	- Lot of conflicting routes are fixed with http verb in front of them
- Views fix
	- Slim fixes at app/views/proposals/_form.html.slim
	- id was missing at app/views/users/_index.html.slim
- Javascript fixes
	- Needed to manually add jquery 1.4
- Hacks
	- Primary key issue https://stackoverflow.com/questions/33742967/primary-key-issue-with-creating-tables-in-rails-using-rake-dbmigrate-command-wi
	- Last comment issue https://stackoverflow.com/questions/35893584/nomethoderror-undefined-method-last-comment-after-upgrading-to-rake-11

- To fix
	- JS works fine on dev not on prod
	- Changes to all controllers to support strong parameters
  • Loading branch information
xw19 committed Jul 4, 2019
1 parent ea1ecb2 commit 656e101
Show file tree
Hide file tree
Showing 33 changed files with 828 additions and 447 deletions.
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,7 @@ config/database.yml
.sass-cache

coverage/

config/settings.local.yml
config/settings/*.local.yml
config/environments/*.local.yml
30 changes: 17 additions & 13 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
source 'http://rubygems.org'

gem 'rails', '~> 3.2.2'
gem 'rails', '~> 4.2.0'
gem 'mysql2'

# core function gems
gem 'devise', '~> 2.0.0'
gem 'omniauth', '~> 1.0.1'
gem 'inherited_resources', '~> 1.3.0'
gem 'simple_form', '~> 2.0.0'
gem 'nested_form', '~> 0.2.0'
gem 'squeel', '~> 0.9.3'
gem 'devise'
gem 'omniauth'
gem 'inherited_resources'
gem 'simple_form'
gem 'nested_form'
gem 'squeel'
gem 'rails_config'
gem 'has_scope'
gem 'kaminari'
gem 'rake'

# geo related gems
gem 'carmen'
Expand All @@ -25,17 +26,16 @@ gem 'modernizr-rails'
gem 'jquery-rails'
gem 'mini_magick'
gem 'carrierwave'
gem 'client_side_validations', '~> 3.1.0'
gem 'client_side_validations'
gem 'client_side_validations-simple_form'

# asset compilation
gem 'execjs'
gem 'therubyracer'

group :assets do
gem 'sass-rails'
gem 'coffee-rails'
gem 'uglifier'
end
gem 'sass-rails'
gem 'coffee-rails'
gem 'uglifier'

group :development, :test do
gem 'capybara', '~> 1.1.2'
Expand All @@ -52,3 +52,7 @@ group :test do
gem 'turn', :require => false
gem 'simplecov', :require => false
end

gem 'config'
gem 'activeresource'
gem 'protected_attributes'
Loading

0 comments on commit 656e101

Please sign in to comment.