minidlna: use free_port helper (Homebrew#57982)

xvilo · Jul 15, 2020 · 24b1162 · 24b1162
1 parent 6376d45
commit 24b1162
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/Formula/minidlna.rb b/Formula/minidlna.rb
@@ -102,14 +102,12 @@ def plist
       log_dir=#{testpath}/.config/minidlna
     EOS
 
-    system sbin/"minidlnad", "-f", "minidlna.conf", "-p", "8081", "-P",
+    port = free_port
+
+    system sbin/"minidlnad", "-f", "minidlna.conf", "-p", port.to_s, "-P",
                              testpath/"minidlna.pid"
     sleep 2
 
-    begin
-      assert_match /MiniDLNA #{version}/, shell_output("curl localhost:8081")
-    ensure
-      Process.kill("SIGINT", File.read("minidlna.pid").to_i)
-    end
+    assert_match /MiniDLNA #{version}/, shell_output("curl localhost:#{port}")
   end
 end