Potential ArgumentOutOfRangeException in InlineDataMustMatchTheoryPar…

…ameters (xunit/xunit#2823)
xunit · Nov 28, 2023 · 08daceb · 08daceb
1 parent 5c1edb6
commit 08daceb
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/xunit.analyzers/X1000/InlineDataMustMatchTheoryParameters.cs b/src/xunit.analyzers/X1000/InlineDataMustMatchTheoryParameters.cs
@@ -138,7 +138,7 @@ public override void AnalyzeCompilation(
 							context.ReportDiagnostic(
 								Diagnostic.Create(
 									Descriptors.X1012_InlineDataMustMatchTheoryParameters_NullShouldNotBeUsedForIncompatibleParameter,
-									dataParameterExpressions[valueIdx].GetLocation(),
+									valueIdx < dataParameterExpressions.Count ? dataParameterExpressions[valueIdx].GetLocation() : null,
 									builder.ToImmutable(),
 									parameter.Name,
 									SymbolDisplay.ToDisplayString(paramsElementType ?? parameter.Type)
@@ -164,7 +164,7 @@ public override void AnalyzeCompilation(
 							context.ReportDiagnostic(
 								Diagnostic.Create(
 									Descriptors.X1010_InlineDataMustMatchTheoryParameters_IncompatibleValueType,
-									dataParameterExpressions[valueIdx].GetLocation(),
+									valueIdx < dataParameterExpressions.Count ? dataParameterExpressions[valueIdx].GetLocation() : null,
 									builder.ToImmutable(),
 									parameter.Name,
 									SymbolDisplay.ToDisplayString(paramsElementType ?? parameter.Type)
@@ -189,7 +189,7 @@ public override void AnalyzeCompilation(
 					context.ReportDiagnostic(
 						Diagnostic.Create(
 							Descriptors.X1011_InlineDataMustMatchTheoryParameters_ExtraValue,
-							dataParameterExpressions[valueIdx].GetLocation(),
+							valueIdx < dataParameterExpressions.Count ? dataParameterExpressions[valueIdx].GetLocation() : null,
 							builder.ToImmutable(),
 							values[valueIdx].ToCSharpString()
 						)