Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to es6 #18

Merged
merged 8 commits into from
Oct 18, 2017
Merged

feat: update to es6 #18

merged 8 commits into from
Oct 18, 2017

Conversation

yugasun
Copy link
Collaborator

@yugasun yugasun commented Oct 17, 2017

@yugasun yugasun changed the title feat: update to es6 feat: update to es6, fix #16 Oct 17, 2017
@yugasun yugasun changed the title feat: update to es6, fix #16 feat: update to es6 Oct 17, 2017
@xuexb
Copy link
Owner

xuexb commented Oct 17, 2017

@yugasun 你代码有使用什么 eslint 检查吗?如果有也添加下配置吧。

after
});
})
try {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里有问题,本身我调 getReleaseByTag 方向后是在 reject 里执行的回调,意思是先获取有没有发布的 releases note 如果有,则忽略,如果没有,则创建。

如果换成 async await 应该得在 catch 里处理了, getReleaseByTag 这个方法应该会抛异常。(待我抽空测下)

@yugasun
Copy link
Collaborator Author

yugasun commented Oct 17, 2017

@xuexb 我有eslint standard javascript 的标准,但是,你的代码风格完全不一样.....

@xuexb
Copy link
Owner

xuexb commented Oct 17, 2017

@yugasun 你加 eslint 配置啊!你加了我肯定也是按她的啊。

@yugasun
Copy link
Collaborator Author

yugasun commented Oct 17, 2017

@xuexb 好吧,明天一并加上,先别merge,关于你说的问题,我再加处理逻辑

Copy link
Owner

@xuexb xuexb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6的飞起,开源有你更精彩!

@xuexb xuexb merged commit b447cbe into xuexb:master Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Github API for Commit History for Tagged Release
3 participants