-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to es6 #18
Conversation
yugasun
commented
Oct 17, 2017
•
edited
Loading
edited
- Use async/await to handle async functions and
- fix Use Github API for Commit History for Tagged Release #16
- add eslint for code checking
- use husky to handle git hooks
@yugasun 你代码有使用什么 eslint 检查吗?如果有也添加下配置吧。 |
after | ||
}); | ||
}) | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里有问题,本身我调 getReleaseByTag
方向后是在 reject
里执行的回调,意思是先获取有没有发布的 releases note 如果有,则忽略,如果没有,则创建。
如果换成 async await 应该得在 catch
里处理了, getReleaseByTag
这个方法应该会抛异常。(待我抽空测下)
@xuexb 我有eslint standard javascript 的标准,但是,你的代码风格完全不一样..... |
@yugasun 你加 eslint 配置啊!你加了我肯定也是按她的啊。 |
@xuexb 好吧,明天一并加上,先别merge,关于你说的问题,我再加处理逻辑 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6的飞起,开源有你更精彩!