Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable export-all to have a quoted name #36

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

fabiosantoscode
Copy link
Contributor

@fabiosantoscode fabiosantoscode commented Sep 18, 2024

Support quoted names in export-all:

export * as "xx" from "./foo.json"

Imports are already covered because the plugin calls into parseImportSpecifiers.

The required version of acorn has been increased to 1.8.1 because that's when checkExport became able to check quoted exports.

Closes #20

@xtuc xtuc merged commit f2b2d35 into xtuc:main Oct 8, 2024
3 checks passed
@fabiosantoscode
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing error when parsing reexport statement that exports a specifier that is not a valid identifier
2 participants