Do not compress or alter any image inside the pdf #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xthiago
requested changes
May 4, 2017
There was a problem hiding this comment.
@alberto2perez I suggest a minor change in order to keep compatible with old versions of Symfony Filesystem and Process.
| "symfony/filesystem": "~2.3", | ||
| "symfony/process": "~2.3" | ||
| "symfony/filesystem": "~3.1", | ||
| "symfony/process": "~3.1" |
There was a problem hiding this comment.
Could you try to change these version constraints to >=2.3.0 < 4 and check if everything keeps working?
|
@alberto2perez I will merge this PR now. The issue with symfony components version will be fixed by #16. Thank you! |
xthiago
approved these changes
Feb 13, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GS is compressing images and the result was not good at all, most pdfs are already optimized so I wanted to preserve images as they are in the pdf without applying any compression with GS.