[eclipse/xtext#2721] use maven gson instead of orbit gson #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
szarnekow
reviewed
Jun 30, 2023
| @@ -19,7 +19,7 @@ | |||
| <repository location="https://download.eclipse.org/modeling/tmf/xtext/updates/nightly/"/> | |||
| </location> | |||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> | |||
| <unit id="com.google.gson" version="2.10.1.v20230109-0753"/> | |||
| <unit id="com.google.gson" version="2.10.1"/> | |||
There was a problem hiding this comment.
Hmm the manifest of gson 2.10.1 has
Export-Package: com.google.gson;uses:="com.google.gson.reflect,com.googl
e.gson.stream";version="2.10.1",
com.google.gson.annotations;version="2.10.1",
com.google.gson.reflect;version="2.10.1",
com.google.gson.stream;version="2.10.1"
Import-Package: sun.misc;resolution:=optional,com.google.gson.annotations
It imports its own package without a version constraint and exports it with a version constraint.
The orbit gson doesn't look great either:
Export-Package: com.google.gson.internal;x-internal:=true;version="2.10.1";uses:="com.google.gson,com.google.gson.reflect,com.google.gson.stream",
com.google.gson.internal.bind;x-internal:=true;version="2.10.1";uses:="com.google.gson,com.google.gson.internal,com.google.gson.reflect,com
.google.gson.stream",
com.google.gson.internal.bind.util;x-internal:=true;version="2.10.1",
com.google.gson.internal.reflect;x-internal:=true;version="2.10.1";uses:="com.google.gson",
com.google.gson.internal.sql;x-internal:=true;version="2.10.1";uses:="com.google.gson,com.google.gson.i
nternal.bind",
com.google.gson;version="2.10.1";uses:="com.google.gson.internal,com.google.gson.reflect,com.google.gson.stream",
com.google.gson.annotations;version="2.10.1",
com.google.gson.reflect;version="2.10.1",
com.google.gson.stream;version="2.10.1"
Import-Package: com.google.gson;version="[2.10,3)",
com.google.gson.annotations;version="[2.10,3)",
com.google.gson.internal;version="[2.10,3)",
com.google.gson.internal.bind;version="[2.10,3)",
com.google.gson.internal.bind.util;version="[2.10,3)",
com.google.gson.internal.reflect;version="[2.10,3)",
com.google.gson.internal.sql;version="[2.10,3)",
com.google.gson.reflect;version="[2.10,3)",
com.google.gson.stream;version="[2.10,3)",sun.misc;resolution:=optional
I assume the Maven definition uses substitutable API package imports of exported packages (https://docs.osgi.org/specification/osgi.core/8.0.0/framework.module.html#i3238802) so seems to be more correct.
szarnekow
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[eclipse/xtext#2721] use maven gson instead of orbit gson