Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codenvy to the list of xTerm supporters #464

Merged
merged 1 commit into from
Jan 9, 2017
Merged

Add Codenvy to the list of xTerm supporters #464

merged 1 commit into from
Jan 9, 2017

Conversation

TylerJewell
Copy link
Contributor

This is the follow-on PR per @Tyriar and @parisk.

@@ -120,7 +121,11 @@ Visit https://lair.io/sourcelair/xterm and follow the instructions. All developm

#### [Eclipse Che](http://www.eclipse.org/che)

You can start Eclipse Che with `docker run eclipse/che start`
You can start Eclipse Che with `docker run eclipse/che start`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parisk should we remove the "Known tools that use xterm.js internally" list as it pretty much duplicates the real world uses?

@TylerJewell
Copy link
Contributor Author

It did strike me as odd that there were two sections - I couldn't really differentiate the meaning of the two.

@Tyriar
Copy link
Member

Tyriar commented Jan 9, 2017

I initially thought it was:

  • Here are products that use xterm.js
  • Here are tools you can use to develop it

The second section isn't really necessary though imo.

@TylerJewell
Copy link
Contributor Author

Just to keep things a bit more organized, with Eclipse Che, we have had to move anything related to making a contribution into either a CONTRIBUTION.md file (the highlights) and if you are an active developer of the project, we move all of the development workflow into a series of documents contained within the project's wiki. It's harder to maintain, but it keeps the initial README a bit simpler to get your arms around, and then have it more focused on the end user than a project contributor.

@parisk parisk self-requested a review January 9, 2017 17:16
@parisk
Copy link
Contributor

parisk commented Jan 9, 2017

Yep, now that it started getting bigger, I think it pretty much looks like a duplicate.

I will move forward with merging it and I will open up a new PR to rephrase things.

Thanks @TylerJewell for your contribution!

@parisk parisk merged commit aee8dde into xtermjs:master Jan 9, 2017
@Tyriar Tyriar modified the milestone: 2.3.0 Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants