Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use node-pty for Windows support #442

Merged
merged 3 commits into from
Jan 15, 2017
Merged

Use node-pty for Windows support #442

merged 3 commits into from
Jan 15, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 1, 2017

Fixes #441

This combined with #435 Windows dev should work. This is the fork used in Hyper and VS Code, I will publish a named release soon, see the README.

image

@Tyriar Tyriar self-assigned this Jan 1, 2017
@Tyriar Tyriar requested a review from parisk January 1, 2017 16:26
@Tyriar Tyriar modified the milestone: 2.3.0 Jan 4, 2017
@Tyriar Tyriar changed the title Use Tyriar/pty.js for Windows support Use node-pty for Windows support Jan 8, 2017
@Tyriar Tyriar added the work-in-progress Do not merge label Jan 8, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Jan 8, 2017

This is blocked on the gulp build #435

@Tyriar Tyriar removed the work-in-progress Do not merge label Jan 15, 2017
@Tyriar
Copy link
Member Author

Tyriar commented Jan 15, 2017

@parisk ready for review

@Tyriar
Copy link
Member Author

Tyriar commented Jan 15, 2017

Just tested again after rebase, works on Windows!

parisk
parisk approved these changes Jan 15, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. 👍

@Tyriar Tyriar merged commit 8a07b8c into xtermjs:master Jan 15, 2017
@Tyriar Tyriar deleted the 441_windows_support branch January 15, 2017 10:38
@Tyriar Tyriar modified the milestone: 2.3.0 Feb 2, 2017
PerBothner added a commit to PerBothner/DomTerm that referenced this pull request Feb 28, 2023
@PerBothner
Add wrapper <div> around xterm.element, unless whole window.
050c10b 
This is to work around the FitAddon measuring the parent element
of the xterm element - see xtermjs/xterm.js#442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @parisk