Underline style and color rendering #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for storing them in a packed format for glyph caching
|
Colors done too: DOM
Canvas
Webgl
|
|
No more overlapping of text/underline: |
|
Continuous curves 😍
|
|
dpr 1 curly rendering on Windows isn't great atm:
|
|
Updated, it was bad when line width was 1:
|
|
Glyph threshold clearing is causing an issue for underlines:
|
This causes some underlines to disappear which looks very bad for colored underlines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1145
This sets up the infrastructure for 3-keyed glyphs where the new key is
ext. Currentlyextis set tounderlineStylebut will be moved to use the packedextformat, similar tofg/bg.DOM
Canvas
Webgl