pixel perfect canvas rendering of box and block characters #3416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Daniel Imms <daimms@microsoft.com>
Co-authored-by: Megan Rogge <merogge@microsoft.com>
…xterm.js into merogge/pixelPerfect
meganrogge
commented
Aug 16, 2021
|
Progress (canvas):
Old webgl rendering:
|
|
w3 alignment tests in canvas:
Looks like these are aligned wrong above: old in webgl:
|
|
Webgl line height, letter spacing works. Plus the shade characters work 🎉
|
|
Had a think about testing and can't really think of a nice way to do it across all browsers unless we managed to get it drawing exactly across all browsers. But FF and Chrome seem to differ in how they draw corners of paths so not sure. Going to go ahead on this without tests for now, there is a button at the bottom of the demo that writes the alignment tests to the terminal though. |
No idea why this worked but it did
|
Moving ahead with this, here's canvas (1.1 line height, 1 letter spacing):
Webgl:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2409