Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly size and position the composition view #320

Merged
merged 2 commits into from
Oct 23, 2016
Merged

Correctly size and position the composition view #320

merged 2 commits into from
Oct 23, 2016

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Oct 22, 2016

This PR does the following:

  • Ensures the textarea is kept within the bounds of the viewport by aligning it to the top of the cursor instead of the bottom
  • Takes .xterm-rows offset into account if it's positioned absolutely within .xterm (as in vscode)
  • Forces height and line-height on the composition view to be the size of the cursor

Fixes #299

This was referenced Oct 22, 2016
Closed
Closed
parisk
parisk approved these changes Oct 23, 2016
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Tyriar Tyriar merged commit 8feaacf into xtermjs:master Oct 23, 2016
@Tyriar Tyriar deleted the 299_keep_textarea_in_viewport branch October 23, 2016 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @parisk