Make add-ons load Terminal from dist #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some addon tests are failing |
|
Working on this right now. |
parisk
changed the title
|
Test are passing @Tyriar, can you please take another look at this? |
Tyriar
approved these changes
Oct 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make add-ons load Terminal from
dist, or else they will break on environments with module systems that do not support ES2015 modules.I also tweaked the tests to made sure that the
distconstructor gets overloaded, even ifloadAddonis being called fromsrc/xterm.js. I am not quite happy with this hack though 😕 .Fix #305.