-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commands that fill a non-full buffer lock up the terminal for a couple of seconds #444
Comments
Until the buffer is full, calls to syncScrollArea are triggering tonnes of refresh calls. So it looks like this is related to the scroll bar changing (as in #132) which we avoid now when the buffer is full since the scrollbar does not change as the buffer size and scroll position don't change. |
There's a recursive loop which eventually resolves as terminal data keeps coming in:
|
Minimal repro: |
It's only recursive because the lines keep changing, refresh should be rate limited. |
This prevents 1000 scroll events from firing when the buffer is not full Fixes xtermjs#444
Need to redo the PR as there was an issue and it was reverted (#463), the commit is on |
This is still an issue and a fix would probably involve a custom scroll bar which I'm not sure we want to commit to just yet. |
This is actually only a problem with the way that the attach addon works, as it continually reads in data before the data is parsed. |
Perhaps we can prefill/warm up the buffer in a better way?
Steps to reproduce
yes
VS Code issue: microsoft/vscode#42234
The text was updated successfully, but these errors were encountered: