Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDirtyRowService can be inlined into InputHandler #4147

Closed
Tyriar opened this issue Sep 25, 2022 · 0 comments · Fixed by #4163
Closed

IDirtyRowService can be inlined into InputHandler #4147

Tyriar opened this issue Sep 25, 2022 · 0 comments · Fixed by #4163
Assignees
Labels
type/debt Technical debt that could slow us down in the long run
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 25, 2022

I think it's only used there and on related events:

this.register(this._bufferService.onScroll(event => {
this._onScroll.fire({ position: this._bufferService.buffer.ydisp, source: ScrollSource.TERMINAL });
this._dirtyRowService.markRangeDirty(this._bufferService.buffer.scrollTop, this._bufferService.buffer.scrollBottom);
}));
this.register(this._inputHandler.onScroll(event => {
this._onScroll.fire({ position: this._bufferService.buffer.ydisp, source: ScrollSource.TERMINAL });
this._dirtyRowService.markRangeDirty(this._bufferService.buffer.scrollTop, this._bufferService.buffer.scrollBottom);
}));

Encapsulating this over having a service will simplify the codebase.

@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Sep 25, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Oct 1, 2022
@Tyriar Tyriar added this to the 5.1.0 milestone Oct 1, 2022
@Tyriar Tyriar self-assigned this Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant