Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider ignoring all alt+<keypress> events on Windows #384

Closed
Tyriar opened this issue Nov 28, 2016 · 3 comments
Closed

Consider ignoring all alt+<keypress> events on Windows #384

Tyriar opened this issue Nov 28, 2016 · 3 comments
Labels
type/proposal A proposal that needs some discussion before proceeding

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 28, 2016

alt+letter is used to access menus on Windows. I'm not aware of any Windows programs accepting these key sequences so maybe they should just be ignored?

See microsoft/vscode#10525
@Tyriar Tyriar added the type/proposal A proposal that needs some discussion before proceeding label Nov 28, 2016
@Tyriar Tyriar mentioned this issue Nov 28, 2016
Closed
@hjwp
Copy link

hjwp commented Dec 15, 2016

Lots of console/terminal applications need the alt key to work correctly. emacs, vim, bash... Would this proposal break them?

@parisk
Copy link
Contributor

parisk commented Dec 15, 2016

I think this should be handled by the consumer app with attachCustomKeydownHandler and not xterm.js itself. What do you think @Tyriar?

@Tyriar
Copy link
Member Author

Tyriar commented Dec 15, 2016

I might see what powershell, cmd, cmder, etc. do for this in vscode, thanks 😃

@Tyriar Tyriar closed this as completed Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/proposal A proposal that needs some discussion before proceeding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hjwp @parisk @Tyriar