Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt + F not triggering "File menu" #10525

Closed
jjacode opened this issue Aug 14, 2016 · 15 comments
Closed

Alt + F not triggering "File menu" #10525

jjacode opened this issue Aug 14, 2016 · 15 comments
Assignees
Labels
*as-designed Described behavior is as designed terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@jjacode
Copy link

jjacode commented Aug 14, 2016

  • VSCode Version: 1.4.0
  • OS Version: Windows 10 Pro

Steps to Reproduce:

  1. In VSCode, press Alt + F (or Alt + E/V/G/H)
  2. Notice the dropdown menu that isn't showing up as it used to (But the Key hints show up under respective menu items)
@bpasero
Copy link
Member

bpasero commented Aug 15, 2016

@jjacode I cannot reproduce on my Windows 10, sorry.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Aug 15, 2016
@bpasero bpasero added this to the Backlog milestone Aug 15, 2016
@bpasero
Copy link
Member

bpasero commented Sep 18, 2016

@jjacode could you give our insider release a try to see if this issue is fixed?
You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders

@bpasero bpasero closed this as completed Sep 23, 2016
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Sep 29, 2016

Cannot reproduce in VS Code 1.5.3 on Windows 10 either. Removing the "bug" label". @jjacode let us know if you still face issues

@ramya-rao-a ramya-rao-a added *not-reproducible Issue cannot be reproduced by VS Code Team member as described and removed bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Sep 29, 2016
@jjacode
Copy link
Author

jjacode commented Sep 29, 2016

This only appears to be reproducible when the integrated terminal has focus.

@bpasero
Copy link
Member

bpasero commented Sep 29, 2016

I think the integrated terminal steals all keypresses. @Tyriar can comment on that.

@Tyriar
Copy link
Member

Tyriar commented Sep 29, 2016

@jjacode the terminal consumes most keypresses with the exception of the commands listed in the terminal.integrated.commandsToSkipShell setting and ones which xterm.js doesn't care about. The alt shortcuts for the menu work fine on Linux while focusing the terminal though, I'll have a quick look when I'm on Windows.

@Tyriar Tyriar reopened this Sep 29, 2016
@Tyriar Tyriar assigned Tyriar and unassigned bpasero Sep 29, 2016
@Tyriar Tyriar modified the milestones: October 2016, Backlog Sep 29, 2016
@ramya-rao-a ramya-rao-a added bug Issue identified by VS Code Team member as probable bug and removed *not-reproducible Issue cannot be reproduced by VS Code Team member as described labels Sep 29, 2016
@jjacode
Copy link
Author

jjacode commented Sep 29, 2016

@Tyriar I've not tried it in Linux yet. But, in Windows when I press Alt the File Menu does the underlining like expected (File underlines "f", Edit underlines "E", etc). But then the terminal captures the letter.

EDIT: I just updated VS Code to 1.5.3, and the issue remains. I'm still in Windows 10.

@Tyriar
Copy link
Member

Tyriar commented Sep 29, 2016

Do you press alt and then f, not alt+f at the same time? I think that's an Electron thing.

@jjacode
Copy link
Author

jjacode commented Sep 29, 2016

I'm pressing and holding Alt, then with Alt still pressed I press "F"

Alt+f at the same time.

@Tyriar Tyriar modified the milestones: Backlog, October 2016 Oct 22, 2016
@Tyriar Tyriar added the terminal General terminal issues that don't fall under another label label Oct 22, 2016
@Tyriar
Copy link
Member

Tyriar commented Oct 22, 2016

Repro'd on Windows, xterm.js must be consuming the keystrokes for some reason.

@iamzhout
Copy link

I also have the same problem, all menu will not popup when hitting alt + f / e / v / g / h

  • VSCode Version: latest stable 1.6.1
  • OS Version: Windows 7

@nrkn
Copy link

nrkn commented Nov 27, 2016

I've just started having this issue today. Was working fine yesterday, and the last update was a week ago so it's been working fine for some days until now.

VSCode 1.7.2
Windows 10

Edit: worked again after restarting Windows

@Tyriar
Copy link
Member

Tyriar commented Nov 28, 2016

Created an upstream issue xtermjs/xterm.js#384

@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Nov 28, 2016
@Tyriar Tyriar removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Dec 15, 2016
@Tyriar
Copy link
Member

Tyriar commented Dec 15, 2016

Upstream doesn't want this for good reason. Should check what powershell, cmd, cmder, etc. do with their alt+shortcuts/menus and see if we need a flexible solution, a on/off setting or maybe we can just hardcode them.

@Tyriar
Copy link
Member

Tyriar commented Apr 20, 2017

Closing since this is as designed upstream, see xtermjs/xterm.js#384

@Tyriar Tyriar closed this as completed Apr 20, 2017
@Tyriar Tyriar added *as-designed Described behavior is as designed upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed bug Issue identified by VS Code Team member as probable bug labels Apr 20, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

6 participants