Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move assert_allclose to general to avoid a hard dependency on pytest #133

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

szymonlopaciuk
Copy link
Contributor

Description

The module xobjects.test_helpers has so far only been used in testing, however currently the function assert_allclose is imported from in in __init__.py making it part of the main package. The test_helpers module requires pytest, which we don't necessarily want to be a required dependency, but the current implementation effectively makes it so. This PR moves the assert_allclose function to xobjects.general instead to avoid this problem.

@szymonlopaciuk szymonlopaciuk mentioned this pull request Apr 22, 2024
@szymonlopaciuk szymonlopaciuk merged commit 4f88d51 into xsuite:main Apr 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant