Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML ID 중복 수정 #88

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

HTML ID 중복 수정 #88

wants to merge 6 commits into from

Conversation

mjy9088
Copy link
Contributor

@mjy9088 mjy9088 commented Dec 8, 2021 •
edited
Loading

일부 ID가 private_text, private_text_reply로 고정됨 -> ID에 app('xe.keygen')->generate() 추가

  • 한 화면에 다른 댓글에 대한 2개 이상의 uio 사용 시 ID 중복 - 해결
  • 한 화면에 같은 댓글에 대한 2개 이상의 uio 사용 시 ID 중복 - 해결

@mjy9088 mjy9088 changed the base branch from master to develop December 8, 2021 06:48
@mjy9088 mjy9088 mentioned this pull request Dec 8, 2021
Open
@mjy9088 mjy9088 changed the title [DRAFT] 댓글 ID 중복 수정 [DRAFT] HTML ID 중복 수정 Dec 8, 2021
@mjy9088 mjy9088 assigned mjy9088 and xharpenParksuhyeon and unassigned mjy9088 Dec 10, 2021
@mjy9088 mjy9088 marked this pull request as ready for review December 29, 2021 09:47
@mjy9088 mjy9088 changed the title [DRAFT] HTML ID 중복 수정 HTML ID 중복 수정 Dec 29, 2021
@mjy9088
Copy link
Contributor Author

mjy9088 commented Dec 29, 2021 •
edited
Loading

@xharpenParksuhyeon id에 app('xe.keygen')->generate()를 추가했습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bi-kim bi-kim

@xharpenParksuhyeon xharpenParksuhyeon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjy9088 @bi-kim @xharpenParksuhyeon