Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unittests from core #95

Closed
wants to merge 4 commits into from
Closed

Conversation

thekid
Copy link
Member

@thekid thekid commented Jul 31, 2015

This pull request implements the third part of xp-framework/rfc#293 and extracts the unittest package from core. The core tests are run via a bundled release of the unittest library (necessary not to produce recursive dependencies!)

The unittest package contents have been split into:

@thekid thekid added this to the 6.5.0 milestone Jul 31, 2015
@thekid
Copy link
Member Author

thekid commented Jul 31, 2015

Libraries will have to add a dependency to their composer.json when this is implemented.

"require" : {
  "xp-framework/core": "^6.3",
  "xp-framework/unittest": "^6.5"   //<--this
}

@thekid thekid changed the title Extract unittests from core Remove unittests from core Aug 6, 2015
@thekid thekid modified the milestones: 7.0.0, 6.5.0 Aug 6, 2015
@thekid
Copy link
Member Author

thekid commented Aug 6, 2015

Postponed until 7.0.0-RELEASE, this would break too many libraries using ~6.0 as dependency (the default before the ^-operator was introduced).

From 6.5.0 on, the extracted libraries will work as overlays (see #96): This way, libraries can add a dependency to them (and also benefit from new features), but if they don't, they'll just use the bundled version.

@thekid thekid added the rfc label Aug 6, 2015
@thekid
Copy link
Member Author

thekid commented Dec 9, 2015

Implemented in https://github.com/thekid/core/tree/seven

@thekid thekid closed this Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant