-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tooltips to playback controls #352
Conversation
Hi there, thanks for the PR! Quick review from my phone: I think the tooltips for play and pause are not translated? |
That's correct, I guess I should've asked before adding the "translatable" attribute. Does text like this need to support a certain set of languages (other than English) before being merged, if any? |
Oh, and I forgot to ask about the code portion of the text generation (which I think you were referring to originally): |
This project uses GNU gettext; anytime you need a string from source code to be translated, wrap it in a call to the gettext macro or fn, you'll see multiple instances of it throughout the code. Then you can run the meson commands mentioned in the README to extract these strings (as well as the strings marked as translatable in the ui files): they will be added to all currently supported languages but will be blank initially and will fallback English, but people will be able to contribute translations from there :) |
LGTM, thanks for your work, merging! :) |
On second thought, I merged this a bit fast, maybe the tooltip for the Repeat button could use some improvement since it switches between three different "modes", but no big deal obviously :) |
Ah, good point. I completely forgot about that as I don't use that button often. Example:
If I find some more time, I will open a PR if someone else hasn't already. |
Small change to add tool tips to the playback controls.