[Button] Ability to set custom icon element instead of name. Ability to set icon styles. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 8, 2017 16:58
Moved styles for button's icon into theme.
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 79.37% 79.44% +0.06%
==========================================
Files 16 16
Lines 708 715 +7
Branches 94 99 +5
==========================================
+ Hits 562 568 +6
- Misses 146 147 +1Continue to review full report at Codecov.
|
|
Hey man, thank you ;) |
matthewfbenjamin
pushed a commit
to theemployeeapp/react-native-material-ui
that referenced
this pull request
Jul 17, 2017
…hal#92) Ability to set icon styles. * [Button] Ability to set custom icon element instead of name. Moved styles for button's icon into theme. * Fixed button tests. * Fixed button tests. * Fixed button tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For needs to create something like
